Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
TAM
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
EIP
Labrador
TAM
Merge requests
!64
Renaming Refactor
Code
Review changes
Check out branch
Open in Workspace
Download
Patches
Plain diff
Expand sidebar
Merged
Renaming Refactor
backend_renaming_refactor
into
dev
Overview
1
Commits
2
Pipelines
1
Changes
30
Merged
Renaming Refactor
Otto Visser
requested to merge
backend_renaming_refactor
into
dev
Jun 5, 2018
Overview
1
Commits
2
Pipelines
1
Changes
30
In this merge request, the following changes are committed:
The mocked objects in tests are renamed to portray that they are indeed mocked
The is* methods of repositories are renamed to "exists" method
0
0
Merge request reports
Compare
dev
dev (base)
and
latest version
latest version
fe73cf34
2 commits,
Jun 5, 2018
30 files
+
418
−
417
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
30
src/main/java/nl/tudelft/ewi/tam/repositories/CourseEditionRepository.java
+
2
−
2
View file @ fe73cf34
Edit in single-file editor
Open in Web IDE
Show full file
@@ -184,7 +184,7 @@ public class CourseEditionRepository {
* @param courseId the id of the course to look for
* @return whether a course with the given id exists
*/
public
boolean
isCourse
(
final
int
courseId
)
{
public
boolean
exists
(
final
int
courseId
)
{
final
Object
[]
arguments
=
{
courseId
};
final
int
[]
argumentTypes
=
{
Types
.
INTEGER
};
return
jdbcDaoImpl
.
count
(
GET_COURSE_ID
,
arguments
,
argumentTypes
)
>
0
;
@@ -196,7 +196,7 @@ public class CourseEditionRepository {
* @param courseCode the course code to look for
* @return whether there is a course with the given course code
*/
public
boolean
isCourse
(
final
String
courseCode
)
{
public
boolean
exists
(
final
String
courseCode
)
{
final
Object
[]
arguments
=
{
courseCode
};
final
int
[]
argumentTypes
=
{
Types
.
VARCHAR
};
return
jdbcDaoImpl
.
count
(
GET_COURSE_CODE
,
arguments
,
argumentTypes
)
>
0
;
Loading