Frontend availability

marked as a Work In Progress

By Ruben Keulemans on 2018-06-06T14:26:16 (imported from GitLab project)

added ~25 label

By Geert Habben Jansen on 2018-06-07T09:04:36 (imported from GitLab project)

added 1 commit

• b7aea7d1 - Add tests

Compare with previous version

By Ruben Keulemans on 2018-06-08T12:05:52 (imported from GitLab project)

Revert his before merge

By Geert Habben Jansen on 2018-06-08T12:06:51 (imported from GitLab project)

Please add a comment describing what this does

By Geert Habben Jansen on 2018-06-08T12:07:29 (imported from GitLab project)

Please stay consistent with the current frontend and use snake case for values and methods exported via Vue

By Geert Habben Jansen on 2018-06-08T12:09:25 (imported from GitLab project)

This has a helper method. (It currently only exists in the course manager branch, but that should be merged shortly)

By Geert Habben Jansen on 2018-06-08T12:10:49 (imported from GitLab project)

Maybe add extra text on this page explaining the availability input. Take an example form the course preference page.

By Geert Habben Jansen on 2018-06-08T12:14:06 (imported from GitLab project)

The part inside the if-statement can be replaced by return a.date.localeCompare(b.date) || null

By Geert Habben Jansen on 2018-06-08T12:16:01 (imported from GitLab project)

Once again, please stay consistent with the rest of the frontend and use snake case for methods or data exported via Vue

By Geert Habben Jansen on 2018-06-08T12:17:09 (imported from GitLab project)

Why is this here given you have the same sort method declared on lines 14-21. Either put this comparison in a seperate method or call customSort(a, b, 'date') here

By Geert Habben Jansen on 2018-06-08T12:18:50 (imported from GitLab project)

Why should the linter be disabled here?

By Geert Habben Jansen on 2018-06-08T12:19:19 (imported from GitLab project)

What is the purpose of these lines? You retrieve a function from the store without putting it in a local variable or executing it.

Besides, the data should not be loaded in given you just stored it, so your local copy should be the most recent version.

If you insist on fetching the data from the server, call this.$store.dispatch. If you want the data from the Vuex store, use $store.data.getters

By Geert Habben Jansen on 2018-06-08T12:24:53 (imported from GitLab project)

Maybe move this to a separate file if this functionality might be required somewhere else

By Geert Habben Jansen on 2018-06-08T12:25:44 (imported from GitLab project)

Note how you are using camel case and snake case mixed in this object

By Geert Habben Jansen on 2018-06-08T12:26:43 (imported from GitLab project)

$event can be omitted here, Vue passes it automatically.

Example: https://vuejs.org/v2/guide/events.html#Method-Event-Handlers

By Geert Habben Jansen on 2018-06-08T12:29:36 (imported from GitLab project)

See comment above

By Geert Habben Jansen on 2018-06-08T12:30:07 (imported from GitLab project)

Any reason the top margin is different from the bottom margin?

By Geert Habben Jansen on 2018-06-08T12:30:42 (imported from GitLab project)

Any reason the top margin is different from the bottom margin?

By Geert Habben Jansen on 2018-06-08T12:35:05 (imported from GitLab project)

What is the reason for the href="#" tag?

By Geert Habben Jansen on 2018-06-08T12:32:02 (imported from GitLab project)