Merge branch 'authorisationAnswers' into 'dev2'

Authorisation answers

See merge request !158

server/src/routes/checkboxquestionanswers.ts

@@ -46,6 +46,12 @@ router.post("/", validateBody(checkboxAnswerSchema), async (req, res) => {
       .send("You are not the reviewer of this review");
     return;
   }
+  if (review.submitted) {
+    res
+      .status(HttpStatusCode.FORBIDDEN)
+      .send("The review is already submitted");
+    return;
+  }
   const questionnaire = await review.getQuestionnaire();
   if (!questionnaire.containsQuestion(question)) {
     res

server/src/routes/multiplechoicequestionanswers.ts

@@ -46,6 +46,12 @@ router.post("/", validateBody(multipleChoiceAnswerSchema), async (req, res) => {
       .send("You are not the reviewer of this review");
     return;
   }
+  if (review.submitted) {
+    res
+      .status(HttpStatusCode.FORBIDDEN)
+      .send("The review is already submitted");
+    return;
+  }
   const questionnaire = await review.getQuestionnaire();
   if (!questionnaire.containsQuestion(question)) {
     res

server/src/routes/openquestionanswers.ts

@@ -43,6 +43,12 @@ router.post("/", validateBody(openAnswerSchema), async (req, res) => {
       .send("You are not the reviewer of this review");
     return;
   }
+  if (review.submitted) {
+    res
+      .status(HttpStatusCode.FORBIDDEN)
+      .send("The review is already submitted");
+    return;
+  }
   const questionnaire = await review.getQuestionnaire();
   if (!questionnaire.containsQuestion(question)) {
     res

server/src/routes/rangequestionanswers.ts

@@ -43,6 +43,12 @@ router.post("/", validateBody(rangeAnswerSchema), async (req, res) => {
       .send("You are not the reviewer of this review");
     return;
   }
+  if (review.submitted) {
+    res
+      .status(HttpStatusCode.FORBIDDEN)
+      .send("The review is already submitted");
+    return;
+  }
   const questionnaire = await review.getQuestionnaire();
   if (!questionnaire.containsQuestion(question)) {
     res

server/src/routes/uploadquestionanswers.ts

@@ -48,7 +48,7 @@ router.get("/file", validateQuery(querySchema), async (req, res) => {
     // or reviwer
     (await review.isReviewer(user)) ||
     // or reviewed
-    (assignment.isAtOrBeforeState(AssignmentState.FEEDBACK) &&
+    (assignment.isAtState(AssignmentState.FEEDBACK) &&
       (await review.isReviewed(user)) &&
       review.submitted)
   ) {
@@ -103,6 +103,12 @@ router.post(
         .send("You are not the reviewer of this review");
       return;
     }
+    if (review.submitted) {
+      res
+        .status(HttpStatusCode.FORBIDDEN)
+        .send("The review is already submitted");
+      return;
+    }
     const questionnaire = await review.getQuestionnaire();
     if (!questionnaire.containsQuestion(question)) {
       res