Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
J
jquery-ui-touch-punch
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
EIP
Project Forum
jquery-ui-touch-punch
Commits
e922197a
Unverified
Commit
e922197a
authored
Jan 31, 2019
by
Rich M
Committed by
GitHub
Jan 31, 2019
Browse files
Options
Downloads
Patches
Plain Diff
Notes on jquery-ui dialog and close button
parent
44205e83
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
jquery-ui-notes.txt
+9
-0
9 additions, 0 deletions
jquery-ui-notes.txt
with
9 additions
and
0 deletions
jquery-ui-notes.txt
0 → 100644
+
9
−
0
View file @
e922197a
Whilst implementing this, we noticed that on some mobile phones there were still some issues:
a) If you have a jquery-ui dialog box open, it could be nigh impossible to use the close icon in the top right hand
corner on some phones.
After some experimentation, we found that we had to check if the screen size <= 480 and in that case, set the dialog
"draggable" setting to false
Presumably the phone was struggling to work out if we were trying to drag a box which might only be a couple of pixels smaller
than the width of the screen, or we wanted to hit the close icon.
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment