Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Project Forum Project Forum
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 6
    • Merge requests 6
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • EIPEIP
  • Project ForumProject Forum
  • Project ForumProject Forum
  • Merge requests
  • !611

Resolve "CourseEdition creation button is shown to edition coordinators"

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Martin Mladenov requested to merge 286-courseedition-creation-button-is-shown-to-edition-coordinators into development Dec 18, 2021
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 1

Do not give course edition coordinators the "create" permission.

As described in the CanCanCan documentation, calling can? :create, CourseEdition does not check conditions specified in the ability file, but only checks if the user has the "create" permission on at least one course edition (which they do as they have been granted the "manage" permission on a course edition).

There is a chance this issue may exist in other places in the application as well, as I noticed similar calls to can? with a class passed as the argument.

Closes #286 (closed)

Edited Dec 18, 2021 by Martin Mladenov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 286-courseedition-creation-button-is-shown-to-edition-coordinators