Skip to content
Snippets Groups Projects

CorsPatchFilter NPE

Merged
Ewoud Ruighaverrequested to merge
cors-no-origin-npe into development
All threads resolved!

Description

Fixes a bug where the CorsPatchFilter would throw an NPE on a request without an origin header.

Resolves #242 (closed)

Changes

CorsPatchFilter::requiresHeaderPatchCheck now returns false on requests without a header.

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Erik Oudsen

Merge request reports

Pipeline #221980 passed

Pipeline passed for 9d3d1a47 on cors-no-origin-npe

Approval is optional

Merged by Erik OudsenErik Oudsen Oct 14, 2019 (Oct 14, 2019 11:42am UTC)

Merge details

Pipeline #221986 passed

Pipeline passed for 17ebcc13 on development

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading