Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
LabraCORE
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
EIP
Labrador
LabraCORE
Merge requests
!222
Make sure we first filter on assignment id
Code
Review changes
Check out branch
Open in Workspace
Download
Patches
Plain diff
Expand sidebar
Merged
Make sure we first filter on assignment id
prevent-findByAssignmentIdFiltered-returning-ALL
into
development
Overview
1
Commits
2
Pipelines
6
Changes
1
Merged
Make sure we first filter on assignment id
Cédric Willekens
requested to merge
prevent-findByAssignmentIdFiltered-returning-ALL
into
development
Dec 19, 2023
Overview
1
Commits
2
Pipelines
6
Changes
1
0
0
Merge request reports
Compare
development
version 1
bef261ed
Dec 19, 2023
development (base)
and
latest version
latest version
b0660a01
2 commits,
Dec 19, 2023
version 1
bef261ed
1 commit,
Dec 19, 2023
1 file
+
17
−
9
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
src/main/java/nl/tudelft/labracore/repository/SubmissionRepository.java
+
17
−
9
View file @ b0660a01
Edit in single-file editor
Open in Web IDE
Show full file
@@ -19,8 +19,8 @@ package nl.tudelft.labracore.repository;
import
static
com
.
querydsl
.
jpa
.
JPAExpressions
.
select
;
import
java.util.
List
;
import
java.util.
Optional
;
import
java.util.
*
;
import
java.util.
stream.Collectors
;
import
org.springframework.data.domain.Sort
;
import
org.springframework.data.jpa.repository.JpaRepository
;
@@ -99,14 +99,22 @@ public interface SubmissionRepository
* @return The list of Submissions.
*/
default
List
<
Submission
>
findByAssignmentIdFiltered
(
Long
assignmentId
,
String
filter
,
Boolean
isLatest
)
{
List
<
Submission
>
submissions
=
findAll
(
qs
.
group
.
name
.
likeIgnoreCase
(
"%"
+
filter
+
"%"
)
List
<
Submission
>
submissions
=
findAll
(
qs
.
assignment
.
id
.
eq
(
assignmentId
).
and
(
qs
.
group
.
name
.
likeIgnoreCase
(
"%"
+
filter
+
"%"
)
.
or
(
qs
.
submitter
.
id
.
in
(
select
(
qcp
.
id
).
from
(
qcp
).
where
(
qcp
.
username
.
likeIgnoreCase
(
"%"
+
filter
+
"%"
)))));
return
isLatest
?
submissions
.
stream
().
map
(
Submission:
:
getGroup
).
distinct
()
.
map
(
g
->
findLatestSubmissionForGroup
(
g
.
getId
(),
assignmentId
))
.
filter
(
Optional:
:
isPresent
).
map
(
Optional:
:
get
).
toList
()
:
submissions
;
select
(
qcp
.
id
).
from
(
qcp
).
where
(
qcp
.
username
.
likeIgnoreCase
(
"%"
+
filter
+
"%"
))))));
if
(
isLatest
)
{
// Get the latest assignment per group.
return
submissions
.
stream
().
collect
(
Collectors
.
groupingBy
(
Submission:
:
getGroup
)).
entrySet
()
.
stream
()
.
collect
(
Collectors
.
toMap
(
Map
.
Entry
::
getKey
,
(
l
)
->
l
.
getValue
().
stream
()
.
max
(
Comparator
.
comparing
(
Submission:
:
getSubmissionTime
))))
.
values
().
stream
().
map
(
Optional:
:
get
).
toList
();
}
else
{
return
submissions
;
}
}
/**
Loading