Skip to content

Liam java 11

Liam Clark requested to merge liam-java-11 into development

This is a rebased / reworked version of !177 (closed). Credit to @cedricwilleken for doing the initial migrations The biggest difference between the two branches is:

  1. The schema is stable in this version compared to master. Due to the fixes regarding Id generation. The problem originated because Hibernate reinterpets GenerationType.Auto in newer versions. This pr fixes it to Identity generation as it used to be.
  2. Hibernate ddl is set to validate
  3. A few security classes added in !177 (closed) are now gone namely Encoder and the infamous SavedRequestAwareAuthenticationSuccessHandler
  4. Formatting has been applied in the original commits that introduced the code changes.

Things to review:

  1. SecurityWebApplicationInitializer registers the web security config regardless of profile? is that correct?i
  2. Why is the heroku properties file required?

Things left todo:

  1. Update the contributing guide to mention java 11+ and the command to insert the yaml template.
  2. The redirect to the login page is broken in the dev security setup. (Probably has to do with QueueAuthenticationEntryPoint)
  3. Security in dev setup seems to remember users for to long (even across incognitos?)
  4. The yaml template currently enables: allow-bean-definition-overriding: true which seems slightly hacky.
Edited by Liam Clark

Merge request reports