Liam java 11

This is a rebased / reworked version of !177 (closed). Credit to @cedricwilleken for doing the initial migrations The biggest difference between the two branches is:

1. The schema is stable in this version compared to master. Due to the fixes regarding Id generation. The problem originated because Hibernate reinterpets GenerationType.Auto in newer versions. This pr fixes it to Identity generation as it used to be.
2. Hibernate ddl is set to validate
3. A few security classes added in !177 (closed) are now gone namely Encoder and the infamous SavedRequestAwareAuthenticationSuccessHandler
4. Formatting has been applied in the original commits that introduced the code changes.

Things to review:

1. SecurityWebApplicationInitializer registers the web security config regardless of profile? is that correct?i
2. Why is the heroku properties file required?

Things left todo:

1. Update the contributing guide to mention java 11+ and the command to insert the yaml template.
2. The redirect to the login page is broken in the dev security setup. (Probably has to do with QueueAuthenticationEntryPoint)
3. Security in dev setup seems to remember users for to long (even across incognitos?)
4. The yaml template currently enables: allow-bean-definition-overriding: true which seems slightly hacky.

added 13 commits

• 472d7ece - Refactor queue for java 11
• d6764765 - Fix the tests so they work with java 11
• 9a599677 - Also change pom to reflect the gradle file
• d5b92f64 - Use java 11 compatible image to test code
• 8c738b45 - Migrate ci build and test stages to use java 11+
• 54d3573a - Re-enable redis sessions and make encoder and savedrequestawareauthentication...
• 00b073ed - Add the dependency for redis session data
• d59a3529 - Move thymeleaf and hibernate versions to a variable
• 50209bc4 - Thymeleaf versions dont match apperently to remove them
• 335238b9 - Apply the suggested edits by intellij
• c71450c7 - Pick id generation strategy Identity
• 14bd20e3 - Fix all warnings due to deprecated methods/classes
• 0eb63212 - Remove Encoder and SavedRequestAwareAuthenticationSuccessHandler

Compare with previous version

changed the description

assigned to @cedricwilleken, @otto, @taicoaerts, and @sander

@cedricwilleken The redirect and logout works in development properly again if I remove this line

		http
//				.exceptionHandling().authenticationEntryPoint(new QueueAuthenticationEntryPoint()).and()
				.authorizeRequests()
				.antMatchers("/").permitAll()

Any input on why you added this or why we would want it?

marked the checklist item SecurityWebApplicationInitializer registers the web security config regardless of profile? is that correct?i as completed

marked the checklist item SecurityWebApplicationInitializer registers the web security config regardless of profile? is that correct?i as incomplete

added 1 commit

• ac040524 - Reallign security configs

Compare with previous version

marked the checklist item SecurityWebApplicationInitializer registers the web security config regardless of profile? is that correct?i as completed

marked the checklist item The redirect to the login page is broken in the dev security setup. (Probably has to do with QueueAuthenticationEntryPoint) as completed

marked the checklist item Security in dev setup seems to remember users for to long (even across incognitos?) as completed

marked the checklist item The yaml template currently enables: allow-bean-definition-overriding: true as completed

In ac040524 the bean overriding is no longer required and more extra security classes can be removed. Furthermore the login redirect on dev is working again

added 1 commit

• 25ea8b00 - Reallign security configs

Compare with previous version

marked the checklist item Why is the heroku properties file required? as completed

resolved all threads

@LiamClark regarding

Update the contributing guide to mention java 11+ and the command to insert the yaml template.

Might want to exclude Java 13 here, that requires Gradle 6.x afaik.

marked the checklist item Update the contributing guide to mention java 11+ and the command to insert the yaml template. as completed

resolved all threads

approved this merge request

unapproved this merge request

approved this merge request

@otto seems like the last remaining problem is that the: sast, container scanning, licence check and dependency scan are failing with warnings.

1. container scan fails with: Can't pull fsLayers I have no idea what that is? @otto do you?
2. dependency scanning seems to fail on a configuration error of the annotation processors in the mvn config. For the queryDsl classes.
3. licence validation fails on the java target version: Fatal error compiling: invalid target release: 11 -> [Help 1]. This raises two questions why is this task done through maven? second why is it not running java 11?
4. sast fails on jdk8 aswell

• What went wrong: Execution failed for task ':compileJava'.

Could not target platform: 'Java SE 11' using tool chain: 'JDK 8 (1.8)'.

mentioned in merge request !202 (closed)

Closes: #167 (closed)

mentioned in merge request !210 (merged)

mentioned in merge request !160 (merged)

added 1 commit

• 6eb0c27b - - change caching

Compare with previous version

added 1 commit

• 24c5546a - More refinements on build process and added explanation of build stages

Compare with previous version

added 1 commit

• ea8aa199 - More tweaks to build process

Compare with previous version

added 1 commit

• 6cbb3cc7 - - get rid of maven pom file

Compare with previous version

added 1 commit

• f56cbe05 - Remove gradle install stage as pom can be retrieved from cache

Compare with previous version

added 1 commit

• 0fbd56a4 - - Create pom.xml in build stage

Compare with previous version

added 1 commit

• 36c35186 - Handle the POM as an artifact; not via cache (shared runners do not

Compare with previous version

added 1 commit

• 36a15261 - Global cache policy is now pull; only build pushes

Compare with previous version

added 1 commit

• 07be77d4 - When I say push I mean pull

Compare with previous version

added 1 commit

• c6918bf8 - - Always do license & dependency checks to make sure automagic merge

Compare with previous version

resolved all threads

closes: #210 (closed)

added 6 commits

• 77aaab55 - Refactor queue for java 11
• 61e7d4ef - Pick id generation strategy Identity
• 4dc2ea01 - Fix all warnings due to deprecated methods/classes
• 59e8aad9 - Remove Encoder and SavedRequestAwareAuthenticationSuccessHandler
• 92735c19 - Reallign security configs
• 706bb32e - More refinements on build process and added explanation of build stages

Compare with previous version

added 97 commits

• 706bb32e...c4d13f9b - 91 commits from branch development
• 7b5ddf21 - Refactor queue for java 11
• a9e85ae7 - Pick id generation strategy Identity
• dc7ef6fd - Fix all warnings due to deprecated methods/classes
• 6f6a7f12 - Remove Encoder and SavedRequestAwareAuthenticationSuccessHandler
• a51c9546 - Reallign security configs
• 2b50ac27 - More refinements on build process and added explanation of build stages

Compare with previous version

approved this merge request

started a merge train

merged

mentioned in commit 92a10995