Liam java 11
This is a rebased / reworked version of !177 (closed). Credit to @cedricwilleken for doing the initial migrations The biggest difference between the two branches is:
- The schema is stable in this version compared to master. Due to the fixes regarding Id generation.
The problem originated because Hibernate reinterpets
GenerationType.Auto
in newer versions. This pr fixes it to Identity generation as it used to be. - Hibernate ddl is set to validate
- A few security classes added in !177 (closed) are now gone namely
Encoder
and the infamousSavedRequestAwareAuthenticationSuccessHandler
- Formatting has been applied in the original commits that introduced the code changes.
Things to review:
-
SecurityWebApplicationInitializer
registers the web security config regardless of profile? is that correct?i -
Why is the heroku properties file required?
Things left todo:
-
Update the contributing guide to mention java 11+ and the command to insert the yaml template. -
The redirect to the login page is broken in the dev security setup. (Probably has to do with QueueAuthenticationEntryPoint
) -
Security in dev setup seems to remember users for to long (even across incognitos?) -
The yaml template currently enables: allow-bean-definition-overriding: true
which seems slightly hacky.
Edited by Liam Clark