Skip to content
Snippets Groups Projects

When in a course, history does not limit to that course

What does this MR do?

Filter the requests when "../history/course/XX/student/YY" is visited, such that only the requests to the corresponding course are shown.

Screenshots

The only course that should be shown is Algorithms and Datastructures

Before Screenshot_2020-02-07_at_11.01.42

After Screenshot_2020-02-07_at_10.59.55

Does this MR meet the acceptance criteria?

  • does not limit history to that actual course XX
  • shows history of student ZZ even if ZZ is not in course XX (aka: privacy leaks)

Closes #184 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Lemaire
  • Chris Lemaire
  • Thijs Nulle added 1 commit

    added 1 commit

    • 0cb14f41 - Change the filtering to happen before the database polling. This to make sure...

    Compare with previous version

  • Thijs Nulle added 1 commit

    added 1 commit

    • df2c0a59 - Reverted changes to license headers applied by spotlessApply.

    Compare with previous version

  • Otto Visser resolved all threads

    resolved all threads

  • Otto Visser approved this merge request

    approved this merge request

  • Chris Lemaire approved this merge request

    approved this merge request

  • Chris Lemaire started a merge train

    started a merge train

  • Chris Lemaire mentioned in commit 9ee7848c

    mentioned in commit 9ee7848c

  • unassigned @tnulle

  • Please register or sign in to reply
    Loading