Skip to content
Snippets Groups Projects

Resolve "Re-design smileys on TA feedback"

All threads resolved!

What does this MR do?

Smileys in feedback for TAs are redesigned:

  • buttons are color-coded (in a way indicated in the #291 (closed) issue description)
  • buttons and smileys are larger for better visibility

Smiley button group design

Normal view

Screenshot_2020-03-28_at_18.53.00

Hover-over view (on the angry, red smiley)

Screenshot_2020-03-28_at_18.53.09

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made. (not needed - only UI was changed)
  • Tests were created to test the feature. (not needed - only UI was changed)
  • I have updated the documentation accordingly. (not needed - only UI was changed)
  • I adhere to the style guide.
Edited by Natália Struharová

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks for picking this one up! When running it looks really nice. When you make a visual change in the future, don't forget to include an image so we can all see the change without having to run any code :)

  • Natália Struharová changed the description

    changed the description

  • Natália Struharová marked the checklist item I adhere to the style guide. as completed

    marked the checklist item I adhere to the style guide. as completed

  • added 1 commit

    Compare with previous version

  • Natália Struharová changed the description

    changed the description

  • Natália Struharová marked the checklist item I have updated the documentation accordingly. (not needed - only UI was changed) as completed

    marked the checklist item I have updated the documentation accordingly. (not needed - only UI was changed) as completed

  • Natália Struharová marked the checklist item Tests were created to test the feature. (not needed - only UI was changed) as completed

    marked the checklist item Tests were created to test the feature. (not needed - only UI was changed) as completed

  • Natália Struharová marked the checklist item I have added a changelog entry to reflect the significant changes I made. (not needed - only UI was changed) as completed

    marked the checklist item I have added a changelog entry to reflect the significant changes I made. (not needed - only UI was changed) as completed

  • Chris Lemaire approved this merge request

    approved this merge request

  • Otto Visser resolved all threads

    resolved all threads

  • Otto Visser approved this merge request

    approved this merge request

  • Otto Visser started a merge train

    started a merge train

  • merged

  • Otto Visser mentioned in commit 3a82585b

    mentioned in commit 3a82585b

  • Please register or sign in to reply
    Loading