Resolve "Click on map image of room to show TA where you are"
What does this mr do?
Add an option to select a position on a map when a student enqueues, if a map is available. The TA will see this position whenever they handle a request.
Screenshots
Enqueueing

Student view
TA view
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made. -
Tests were created to test the feature. -
I have updated the documentation accordingly. -
I adhere to the style guide.
Closes #196 (closed)
Merge request reports
Activity
added priohigh typefeature-request labels
@otto is there a way to only have images for debugging? I think a map for debugging using development should be handy if this feature gets implemented.
For the circle, I can add a background shadow but I think we have to draw the line somewhere, it can be added in _variables.scss if that eventually gets merged. That could be an easy way change it on a university basis.
- Resolved by Otto Visser
Perhaps we can add a default works-for-most rooms map? This way this feature will also work if the room has no map yet. So a rectangle with a door for instance?
Not sure if I fully follow here. Will the TZ2 map only be used for TZ2 or were you planning to use it for every room?
Edit: I see Otto's remark now. I agree that a generic map should not have the 4 coloured quadrants, but I also think a generic room is nearly impossible to achieve as every room will be different in door placement, project placement, size, etc.
I think the default should be to not show this place-in-the-room selector at all if no room image can be found. That way you don't get confusion over what indication is where in the room.
Edited by Chris Lemaire
mentioned in merge request !303 (merged)
There's 23 commits for this MR. I understand your progress might be saved in these commits, but it will be useful in the future to be able to look back through these commits and make sense out of the changes you made. Would you be able to squash these commits into a few commits that describe each relevant change and the reasoning for it?
This is honestly a bit of a problem since the commits have been wrong since a wrong rebase, every single commit message almost does not show what is actually added and/or changed. Would a better idea be to completely uncommit everything and build the commit history from the ground up and listing it file by file what has changed?
After a short conversation with @tnulle, we decided to close this MR for Queue 1.2.0 and leave it as a new feature for Labrador Queue (2.0.0)
unassigned @Lemaire