Resolve "[Queue-2.0] Lab page sortability"
What does this mr do?
Sorts the labs on the labs page on whether they are open, have passed, or the starting time. Adds filters for the type of lab and the module of the lab on the page as well.
Screenshots
before
after
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made. -
Tests were created to test the feature. -
I have updated the documentation accordingly. -
I adhere to the style guide.
Closes #370 (closed)
Merge request reports
Activity
added typefeature-request ui + 1 deleted label
- Resolved by Chris Lemaire
added 41 commits
-
4b63e626...d994da2e - 37 commits from branch
queue-v2.0 - 9d3b650b - Add a standard sorting to the lab page
- f306c537 - Add filter for the type of the lab
- fecf58eb - Add remove current filter button to labs page
- 48fefc3d - Add module filter to labs page
Toggle commit list-
4b63e626...d994da2e - 37 commits from branch
requested review from @Lemaire
added 7 commits
-
4fa83cec - 1 commit from branch
development - 50f1fda7 - Add a standard sorting to the lab page
- abe89323 - Add filter for the type of the lab
- 08e24969 - Add remove current filter button to labs page
- 53fd38ea - Add module filter to labs page
- c64c0cf2 - Add some margins to the lab filters
- 5a27e1d2 - Add lab sort and filter to changelog file
Toggle commit list-
4fa83cec - 1 commit from branch
Looks like the build issue should be fixed when branch is rebased on development. Could you do that @wpolet ?
- Resolved by Chris Lemaire
After closely looking at the sorting, I noticed that finished labs are ordered below upcoming labs. This might be slightly confusing without a visual indicator. We should either make a separator for active-upcoming and upcoming-past labs so that they're in separate categories entirely or do a quick fix by adding another label to avoid confusion.
added 17 commits
-
5a27e1d2...8fb7438e - 11 commits from branch
development - 26db6005 - Add a standard sorting to the lab page
- 83b2a617 - Add filter for the type of the lab
- 21447e1a - Add remove current filter button to labs page
- 0765b48f - Add module filter to labs page
- f52e33ee - Add some margins to the lab filters
- 0a3275e6 - Add lab sort and filter to changelog file
Toggle commit list-
5a27e1d2...8fb7438e - 11 commits from branch
added 7 commits
- 17a0fd9d - Add a standard sorting to the lab page
- 39ea3ccb - Add filter for the type of the lab
- e8eed51c - Add remove current filter button to labs page
- 6378c5bd - Add module filter to labs page
- d34f3098 - Add some margins to the lab filters
- 62eb1130 - Add lab sort and filter to changelog file
- c3d67dc5 - Add Completed badge to labs that are done
Toggle commit listenabled automatic add to merge train when the pipeline for 512c9c22 succeeds
mentioned in commit a59fe30d
unassigned @wpolet

