Skip to content
Snippets Groups Projects

Resolve "You should not be able to claim a timeslot that already started"

This MR adds back a missing check to see that a student indeed is trying to take a time-slot that has not already passed. It also adds the possibility to circumvent this check in an advanced option. Additionally, while working on the advanced option, I also added an option to change the (currently hardcoded) pre-slot early-taking period for requests. This setting now defaults to 0.

Closes #146 (closed), #416 (closed)

Edited by Chris Lemaire

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Lemaire added 1 commit

    added 1 commit

    • be13c699 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire resolved all threads

    resolved all threads

  • Chris Lemaire changed the description

    changed the description

  • Chris Lemaire added 11 commits

    added 11 commits

    • be13c699...49434805 - 7 commits from branch development
    • 597107b7 - Add configurations for student enqueue and early taking
    • 5cdc4ebc - Add migrations for adding the new columns
    • 4269a4a4 - Add an additional permission check to ensure proper requests
    • c3f1e1c4 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Otto Visser approved this merge request

    approved this merge request

  • Otto Visser enabled automatic add to merge train when the pipeline for ddb8309d succeeds

    enabled automatic add to merge train when the pipeline for ddb8309d succeeds

  • Chris Lemaire aborted automatic add to merge train because source branch was updated

    aborted automatic add to merge train because source branch was updated

  • Chris Lemaire added 1 commit

    added 1 commit

    • d4048136 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Otto Visser added 3 commits

    added 3 commits

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • d4c9a01d - Merge branch 'development' into...

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 19320c42 - Merge branch 'development' into...

    Compare with previous version

  • Chris Lemaire added 4 commits

    added 4 commits

    • e7f96f50 - Add configurations for student enqueue and early taking
    • 9e02b2c6 - Add migrations for adding the new columns
    • 2b86e4ab - Add an additional permission check to ensure proper requests
    • 254bc13c - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 214ea5a5 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • a38da804 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 1ddbab4c - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 2a235b43 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • b5ee1233 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 39f93a9f - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 86a09319 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • f2ccf505 - Add check for canSelectDueSlots in canTakeSlot

    Compare with previous version

  • Otto Visser approved this merge request

    approved this merge request

  • Otto Visser started a merge train

    started a merge train

  • merged

  • Otto Visser mentioned in commit b3ec1af9

    mentioned in commit b3ec1af9

  • unassigned @Lemaire

  • Please register or sign in to reply
    Loading