Resolve "Can not delete a shared lab from the shared edition overview"
All threads resolved!
What does this mr do?
- Adds the Ability to clone, delete or edit shared labs from the shared lab screen assuming the person is a manager/staff member of that course.
- If a shared lab is deleted, user is redirected to edition collection overview instead of edition overview.
Screenshots
OOP Teacher Perspective
ADS Teacher Perspective
Student Perspective
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made. -
Tests were created to test the feature. - No updates directly to model, therefore no assertions about model can be made. -
I have updated the documentation accordingly. -
I adhere to the style guide.
Closes #577 (closed)
Edited by Henry Page
Merge request reports
Activity
assigned to @hpage
added 1 commit
- 38b63e3b - clean up & refactor all the stupid stuff and fix functionality
added 1 commit
- 114c6c3c - added null to queuesessionsummarydto objects in test suite
added 2 commits
added 12 commits
-
41f3b8e7...2f39089b - 10 commits from branch
development - e7c346a0 - Merge branch 'development' of gitlab.ewi.tudelft.nl:eip/labrador/queue into...
- 0d73b36a - Add test to see if redirection works
-
41f3b8e7...2f39089b - 10 commits from branch
requested review from @cchen9 and @toberhuber
- Resolved by Henry Page
Everything seems to work! Slightly related concern: Cloning makes it easy to end up with two labs with exactly the same name and timing, so maybe a warning should be added if a lab is created in the same course/collection with the same name and time.
requested review from @rbackx and removed review request for @toberhuber and @cchen9
- Resolved by Ruben Backx
Can you move the buttons to the end of the table rows instead of in the middle?
added 4 commits
-
e342fc37...e5d0731d - 2 commits from branch
development - 2228741c - Merge branch 'development' of gitlab.ewi.tudelft.nl:eip/labrador/queue into...
- bb239437 - Move buttons to right
-
e342fc37...e5d0731d - 2 commits from branch
mentioned in commit fb10e67a
Please register or sign in to reply


