Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Queue
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
EIP
Labrador
Queue
Merge requests
!621
Resolve "Can not delete a shared lab from the shared edition overview"
Code
Review changes
Check out branch
Open in Workspace
Download
Patches
Plain diff
Expand sidebar
Merged
Resolve "Can not delete a shared lab from the shared edition overview"
577-can-not-delete-a-shared-lab-from-the-shared-edition-overview
into
development
Overview
4
Commits
15
Pipelines
0
Changes
8
Merged
Resolve "Can not delete a shared lab from the shared edition overview"
Henry Page
requested to merge
577-can-not-delete-a-shared-lab-from-the-shared-edition-overview
into
development
Nov 27, 2022
Overview
4
Commits
15
Pipelines
0
Changes
8
What does this mr do?
Adds the Ability to clone, delete or edit shared labs from the shared lab screen assuming the person is a manager/staff member of that course.
If a shared lab is deleted, user is redirected to edition collection overview instead of edition overview.
Screenshots
OOP Teacher Perspective
ADS Teacher Perspective
Student Perspective
Does this MR meet the acceptance criteria?
I have added a changelog entry to reflect the significant changes I made.
Tests were created to test the feature. - No updates directly to model, therefore no assertions about model can be made.
I have updated the documentation accordingly.
I adhere to the style guide.
Closes
#577 (closed)
Edited
Jan 20, 2023
by
Henry Page
0
0
Merge request reports
Compare
development
version 11
e342fc37
Feb 15, 2023
version 10
e0bba532
Feb 14, 2023
version 9
0d73b36a
Jan 20, 2023
version 8
41f3b8e7
Dec 12, 2022
version 7
39958fe2
Dec 9, 2022
version 6
484c90c9
Dec 9, 2022
version 5
58bc04ef
Dec 9, 2022
version 4
037df4ae
Dec 9, 2022
version 3
114c6c3c
Dec 8, 2022
version 2
e51be57f
Nov 28, 2022
version 1
38b63e3b
Nov 27, 2022
development (base)
and
latest version
latest version
bb239437
15 commits,
Feb 24, 2023
version 11
e342fc37
13 commits,
Feb 15, 2023
version 10
e0bba532
12 commits,
Feb 14, 2023
version 9
0d73b36a
11 commits,
Jan 20, 2023
version 8
41f3b8e7
9 commits,
Dec 12, 2022
version 7
39958fe2
7 commits,
Dec 9, 2022
version 6
484c90c9
6 commits,
Dec 9, 2022
version 5
58bc04ef
5 commits,
Dec 9, 2022
version 4
037df4ae
4 commits,
Dec 9, 2022
version 3
114c6c3c
3 commits,
Dec 8, 2022
version 2
e51be57f
2 commits,
Nov 28, 2022
version 1
38b63e3b
1 commit,
Nov 27, 2022
8 files
+
81
−
5
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
8
src/main/java/nl/tudelft/queue/controller/LabController.java
+
3
−
1
View file @ bb239437
Edit in single-file editor
Open in Web IDE
Show full file
@@ -528,7 +528,9 @@ public class LabController {
ls
.
deleteSession
(
qSession
);
var
session
=
sCache
.
getOrThrow
(
qSession
.
getSession
());
// TODO: Redirect to an edition collection specific page for shared labs
if
(
session
.
getEditionCollection
()
!=
null
)
{
return
"redirect:/shared-edition/"
+
session
.
getEditionCollection
().
getId
();
}
return
"redirect:/edition/"
+
session
.
getEditions
().
get
(
0
).
getId
()
+
"/labs"
;
}
Loading