Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Queue Queue
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 115
    • Issues 115
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 9
    • Merge requests 9
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • EIPEIP
  • LabradorLabrador
  • QueueQueue
  • Merge requests
  • !622

Resolve "Websockets do not respect shared lab staff"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Henry Page requested to merge 555-websockets-do-not-respect-shared-lab-staff into development Dec 11, 2022
  • Overview 3
  • Commits 8
  • Pipelines 0
  • Changes 4

What does this mr do?

Websockets do not respect shared lab staff. Read issue for more desc (#555 (closed))

Actions taken to fix bug

WebsocketService no longer sends messages to everyone in the shared lab, but rather the staff of the edition that the assignment corresponds to.

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
  • A test was created to test the bug.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.

Closes #555 (closed)

Edited Jan 20, 2023 by Henry Page
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 555-websockets-do-not-respect-shared-lab-staff