Skip to content
Snippets Groups Projects

Resolve "Websockets do not respect shared lab staff"

What does this mr do?

Websockets do not respect shared lab staff. Read issue for more desc (#555 (closed))

Actions taken to fix bug

WebsocketService no longer sends messages to everyone in the shared lab, but rather the staff of the edition that the assignment corresponds to.

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
  • A test was created to test the bug.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.

Closes #555 (closed)

Edited by Henry Page

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Overall, the fix works and does what it should!

  • Timur Oberhuber approved this merge request

    approved this merge request

  • Henry Page resolved all threads

    resolved all threads

  • Henry Page requested review from @rbackx and removed review request for @toberhuber and @cchen9

    requested review from @rbackx and removed review request for @toberhuber and @cchen9

  • Henry Page added 1 deleted label

    added 1 deleted label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading