Search persons by identifier

What does this mr do?

Closes issue #99 (closed) . Now you can add a person to an edition by typing (part of) the username, name, student number or the entire email of the person you want to add. The minimum length of the input for their identifier is 4 letters.

This will yield an overview of possible matches, along with their details and then you can add each individual person. You are required to assign a role to the person you want to add before proceeding.

Screenshots

Does this MR meet the acceptance criteria?

• I have added a changelog entry to reflect the significant changes I made.
• Tests were created to test the feature.
• I have updated the documentation accordingly.
• I adhere to the style guide.

added 1 deleted label

requested review from @owvisser and @rwbackx

assigned to @mmadara

changed the description

Security policy violations have been resolved.

marked the checklist item I have updated the documentation accordingly. as completed

marked the checklist item I adhere to the style guide. as completed

marked the checklist item Tests were created to test the feature. as completed

marked the checklist item I have added a changelog entry to reflect the significant changes I made. as completed

Needs a change to 1.5.0-SNAPSHOT.

added 1 commit

• e455695b - Minor changes

Compare with previous version

added 108 commits

• e455695b...5f2d4d52 - 103 commits from branch development
• aee2ca86 - Show table of people to add from
• d50be1bc - Can add any participant
• 47cca442 - Added tests and check for empty role
• dae6ca87 - Minor changes
• 9dab065e - Change minimum to 2

Compare with previous version

resolved all threads

added 1 commit

• 667956f1 - Change minimum to 2

Compare with previous version

added 1 commit

• 3d18e409 - Change minimum to 2

Compare with previous version

added 1 commit

• 757e4c88 - Remove snapshot

Compare with previous version

resolved all threads

approved this merge request

started a merge train

removed this merge request from the merge train because pipeline did not succeed. Learn more.

added 1 deleted label and removed 1 deleted label

added 13 commits

• 757e4c88...9342b3b6 - 7 commits from branch development
• bd5b6e22 - Show table of people to add from
• 447f9e6d - Can add any participant
• 7c13d9df - Added tests and check for empty role
• e1f18a2c - Minor changes
• c47dfb73 - Change minimum to 2
• 2194f190 - Remove snapshot

Compare with previous version

approved this merge request

added 82 commits

• 2194f190...1132a6ab - 79 commits from branch development
• b1c97ea7 - Can add participants by identifier
• a29fc3da - Conflicts
• 65d16913 - Fix import

Compare with previous version

reset approvals from @owvisser and @cedric-dev by pushing to the branch

requested review from @cedricwilleken

added 1 commit

• 233da9c8 - Fix import and license

Compare with previous version

One final comment when using it. Maybe it is nice to display something like 'please enter at least 4 characters to search for people' instead of the 'There were no results found for this identifier!' just to prevent confusion.

requested review from @cedric-dev and removed review request for @cedricwilleken

added 1 commit

• 7f73b5a8 - Ensure min length matches and fix e2e test

Compare with previous version

resolved all threads

added 1 commit

• 83db88ed - Ensure min length matches and fix e2e test

Compare with previous version

added 1 commit

• 363d18dd - Ensure min length matches and fix e2e test

Compare with previous version

added 1 commit

• df242247 - Ensure min length matches and fix e2e test

Compare with previous version

approved this merge request

approved this merge request

started a merge train

removed this merge request from the merge train

added 1 commit

• 1d85a5f0 - Ensure min length matches and fix e2e test

Compare with previous version

reset approvals from @rwbackx and @cedric-dev by pushing to the branch

approved this merge request

enabled automatic add to merge train when the pipeline for 782526f2 succeeds