Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Project Forum Project Forum
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • EIPEIP
  • Project ForumProject Forum
  • Project ForumProject Forum
  • Merge requests
  • !690

Fix approved project scopes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Taico Aerts requested to merge fix-approved-projects into development Mar 30, 2022
  • Overview 7
  • Commits 19
  • Pipelines 0
  • Changes 51
  • Add approved_at to projects, which is set to the initial approval date of the project.
  • Redefine relevant scopes in terms of once_approved (approved_at is set) and remove others
  • Fix last_approved_version to only return something if there was an approved version
  • Add last_approved_version_or_current to perform the old behavior (in case we need to display the last approved version, or otherwise the current version)
  • Simplified some permissions
  • Add ProjectVersioned to load the versioned project or raise exception if never approved (used in normal interface where the pages for unapproved projects should not display anything).
  • Migrate the PaperTrail versions to our new format since we rely on them for the last_approved_version display
  • Sort projects overview by approval date rather than creation date

Closes #337 (closed) #345 (closed)

Edited Apr 03, 2022 by Taico Aerts
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-approved-projects