Skip to content

Fix project import notification and other improvements

Taico Aerts requested to merge 320-fix-companies-notification into development
  • Include actable helper in mailers
  • Fix distinction between named_url and named_path in actable helper. (See #320 (closed) comments)
  • Preload for projects import to fix N+1 issue
  • Redefine original_project as association to allow preloading
  • Redefine Project.untaken scope for compatibility with CourseSpecificRoles.

Since coaches can be present on projects and transfer even to open groups (CSR), the metric used in the past for "project was probably done but just not approved in project forum" is no longer sufficient/checkable reliably. Therefore I decided to remove it.

(If only I knew that before spending a lot of time rewriting the mess of queries that was there into a nice GROUP BY HAVING count >= course_configuration.min_group_size.... ah well...)

Closes #320 (closed)

Merge request reports