Resolve "Recurring logic needs to be updated to not copy over non-approved proposals"

Closes #454 (closed)

changed milestone to %TM - Start

added priocritical statusdoing typeimprovement labels

assigned to @mmladenov

added 2 commits

• 59626e8a - Add test for creating an edition based on a recurrent course edition
• f409ee98 - Copy only approved projects

Compare with previous version

added 1 commit

• dbd6e0c8 - Extend test to cover once approved projects

Compare with previous version

The papertrail versions of a previously approved proposal do not get copied when this proposal is copied to the descendent course edition. This means that proposals that have been approved and then updated will be copied only partially - they will be marked as "once approved" but they will not have the approved version carried over, potentially causing issues.

The test which I wrote demonstrates the issue.

Fixed by ignoring projects that have been updated after approval, and by copying projects on approval. Also added thorough tests. This introduces #460

added 11 commits

• fc04a0da - Save months instead of dates in periods
• 66416b84 - Make it very clear to clients that they are offering a recurrent proposal
• 4037f81d - Change wording
• a3f1a21c - Remove extra space to make Rubocop happy
• 306c9b3a - Allow users to choose descendant course edition when proposing a project
• 0eb20f44 - Fix project linking
• ae8a98c7 - Disable period selection when choosing an individual edition
• dadb6b71 - Change confusing naming
• 1348da9d - Fix styling
• 2f5f2c71 - Improve wording
• 00fdd3ef - Merge branch '453-updates-to-recurrent-course-editions' into...

Compare with previous version

added 39 commits

• 00fdd3ef...33ff85da - 32 commits from branch development
• 443b239c - Copy projects on approval
• e8f7219e - Do not copy to finished course editions
• a9f16028 - Use before update instead of after update
• 3403da1c - Fix status check
• 6d590294 - Update test to verify projects pending update are not copied
• 7033de3c - Add test for approving a recurrent project
• 7963d847 - Merge branch 'development' into...

Compare with previous version

marked this merge request as ready

mentioned in issue #449 (closed)

added 1 commit

• 32c39978 - Remove redundant self

Compare with previous version

mentioned in merge request !799 (merged)

closed