Skip to content
Snippets Groups Projects

Resolve "Creating labs gives 500"

This mr does three things to the lab creation page mentioned in #102 (closed)

  1. The 500 error is gone by fixing a bug in the backend
  2. A form field is now properly aligned with the rest
  3. All validation also happens in the browser with a consistent api, rather than mixing backend / custom alerts and the browser constraint api.

See the individual commit messages for more info

This addresses some important issues from #102 (closed), but the entire story of validation is not entirely resolved. I think we should discuss our strategy regarding validation there.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Lemaire
  • Liam Clark added 1 commit

    added 1 commit

    Compare with previous version

  • Liam Clark resolved all threads

    resolved all threads

  • Otto Visser approved this merge request

    approved this merge request

  • merged

  • Otto Visser mentioned in commit e56b7535

    mentioned in commit e56b7535

  • Chris Lemaire mentioned in merge request !158 (merged)

    mentioned in merge request !158 (merged)

  • Otto Visser mentioned in commit ef3840f9

    mentioned in commit ef3840f9

  • unassigned @Lemaire

  • Please register or sign in to reply
    Loading