Fix request finish button group showing up

• Fixes the request finishing button group showing up for assistants that should not have the right to edit the request status.
• Fixes that teachers could not edit request status after the fact.
• Removes the double checking of assistant identity in RequestService as the permission service call before-hand in RequestController should handle this.

Closes #218 (closed)

added typebug label

Can't say anything meaningful about the bugs or whether this fixes them, however if you are introducing three seperate bug fixes, could you make them three seperate mr's.

This would make it easier to see what logic changes refer to what bug :) Disclaimer; this is a nit pick

added 1 commit

• 9899e809 - Extract conditions into variables with meaningful names

Compare with previous version

resolved all threads

approved this merge request

started a merge train

merged

mentioned in commit da6f1929

mentioned in commit 05f14474