Resolve "Decouple student rights from student role"
Also added an option to delete course participations for staff members and external users. Deleting student enrolments can be done only from the database/Rails console; administrators cannot do this via the UI.
Closes #499 (closed)
Closes #545 (closed)
Merge request reports
Activity
added difficultyhigh priomed statusdoing typeimprovement labels
Resolved by Martin MladenovStudent and coach interests are currently stored in the same table, only distinguished by user role. How should this be handled? I guess students who have a course staff role can't be coaches anyways (right?) so perhaps we don't need to handle this case?
- Last reply by Martin Mladenov
- Resolved by Taico Aerts
Can external users be coaches? If so, some of my changes may have removed that functionality.
- Last reply by Martin Mladenov
- Resolved by Taico Aerts
Perhaps we could also show the student dashboard above the staff dashboard to employees enrolled in at least one active course edition?
- Last reply by Martin Mladenov
added 18 commits
-
3f1c10dd...7b788aab - 15 commits from branch
development - e124c8df - Remove unused file
- 7dc060e7 - Allow employees to be enrolled into course editions manually
- c42c2c61 - Treat employees enrolled in courses as students
Toggle commit list-
3f1c10dd...7b788aab - 15 commits from branch
- Resolved by Taico Aerts
Add tests for students, staff, and external users enrolled in courses:
- All types of users who are enrolled in a course can create and join groups
- All types of users who are enrolled in a course can join interest list as students
- Staff members who are not enrolled in a course can join interest list as coaches
- All types of users who are enrolled in a course can set preferences
- Staff members who are enrolled in a course cannot access supervision page
- All types of users who are enrolled in a course can set student preferences
- All types of users who are enrolled in a course can be added as student preferences
- Staff members / externals who are not enrolled in a course cannot set preferences
- Staff members who are enrolled in a course with a pending/rejected enrolment status cannot see projects
- Course coordinator can delete enrolment for staff member
- Course coordinator can delete enrolment for external user
- Admin cannot delete enrolment for student
- Staff members cannot submit enrolment requests
- External users cannot submit enrolment requests
- Students can cancel pending enrolment requests
- Students cannot cancel approved enrolment requests
- Students cannot cancel rejected enrolment requests
- Staff members cannot cancel pending enrolment requests
- External users cannot cancel pending enrolment requests
- Dashboard tests (?)
Edited by Martin Mladenov - Last reply by Taico Aerts
requested review from @taicoaerts
- Resolved by Martin Mladenov
Currently, there is no way for coordinators to delete an enrolment. As soon as a staff member is enrolled in a course, they will no longer receive staff permissions on that course, regardless of the status of that enrolment.
I guess it makes sense that enrolment requests of students cannot be deleted for legal reasons, but perhaps there should be a way for coordinators to delete enrolments of employees.
Edited by Martin Mladenov - Last reply by Martin Mladenov
added 36 commits
-
703cad02...299d631a - 31 commits from branch
development - 160d8804 - Improve participation_for
- 9eef0461 - Merge branch 'development' into 499-decouple-student-rights-from-student-role
- 16cfb42a - Add missing cancel button in project deletion modal
- 2ecd8158 - Allow deleting non-student enrolments
- 1f669f5e - Fix typo
Toggle commit list-
703cad02...299d631a - 31 commits from branch
- Resolved by Taico Aerts
Can an external user offer a project AND be a student in the same course? :D
- Last reply by Martin Mladenov
added 5 commits
Toggle commit list- Resolved by Martin Mladenov
Should students and external users who are coaches in a course edition be able to join the coach interest list or access the supervision menu?
- Last reply by Martin Mladenov
added 25 commits
-
60950174...cba019a0 - 23 commits from branch
development - f757d776 - Change message to prevent spam to Taico
- a374ab86 - Merge branch 'development' into 499-decouple-student-rights-from-student-role
-
60950174...cba019a0 - 23 commits from branch
mentioned in issue #574
added 36 commits
-
a374ab86...90cb512d - 35 commits from branch
development - d6144364 - Merge branch 'development' into 499-decouple-student-rights-from-student-role
-
a374ab86...90cb512d - 35 commits from branch
mentioned in commit b67a5cad
mentioned in issue #417 (closed)
